Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-table] Bug Fix: Change exported table column width #6243

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

AlexanderReznik
Copy link
Contributor

Description

Exported width does not correspond to the actual width and modifies the proportions between the columns.
700 and 90 seem to be magic numbers. Changing the default exported width to the value from playground css.

Before and After

New behavior for pasting to google docs on top, old one at the bottom:
export-column-width

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 2:41pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 2:41pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.77 KB (0%)
@lexical/rich-text - esm 28.1 KB (0%)
@lexical/plain-text - cjs 35.35 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.51 KB (0%)
@lexical/react - esm 29.12 KB (0%)

@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Jun 3, 2024
@ivailop7 ivailop7 added this pull request to the merge queue Jun 3, 2024
Merged via the queue into facebook:main with commit 573105c Jun 3, 2024
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants