refactor: refactored InlineImageNode - spans for correct HTML #6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58bits
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
approved these changes
May 31, 2024
| @@ -352,7 +352,7 @@ export default function InlineImageComponent({ | |||
| return ( | |||
| <Suspense fallback={null}> | |||
| <> | |||
| <div draggable={draggable}> | |||
| <span draggable={draggable}> | |||
There was a problem hiding this comment.
since inline image is in a span container it does make sense for its children to be span instead of div
currently:
There was a problem hiding this comment.
Thanks @potatowago. I'm actually the author of this plugin and thought I would tidy this up a little ;-)
|
Hi @58bits , sorry for the inconvenience caused in the CI do you mind merging latest Main to this branch before we try remerging this PR to main, to make sure all e2e tests are green. Thanks a lot! |
|
CI pass apart from flaky collab tests which will be addressed in #6238 |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[lexical-playground][inline-image-plugin] Refactor: Spans for correct HTML
Refactor
Description
Refactored InlineImageNode into its own directory, and changed inline image containing divs to spans for technically 'more correct' HTML for inline and float elements. Note that in theory there should be an 'inline' version of ContentEditable too.