Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noisy running time signal mentioned in #6137 #6208

Merged
merged 6 commits into from
May 30, 2024
Merged

Remove noisy running time signal mentioned in #6137 #6208

merged 6 commits into from
May 30, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 30, 2024 •
edited
Loading

WHAT

NOTE:

the given PR workflow "comments" updated to have "running-time" as we are using pull-request-target instead of pull-request, it runs workflow against main branch not current branch. Tested the change locally using pull-request workflow trigger and updated the screenshot below

Before:
Screenshot 2024-05-30 at 11 52 35 AM

After:

Screenshot 2024-05-30 at 11 46 25 AM

@vercel Vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:57am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:57am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.95 KB (0%) 480 ms (0%) 338 ms (+433.34% 🔺) 818 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.64 KB (0%) 693 ms (0%) 351 ms (+63.85% 🔺) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.62 KB (0%) 693 ms (0%) 322 ms (+57.13% 🔺) 1.1 s

@Sahejkm Sahejkm marked this pull request as ready for review May 30, 2024 03:56
@Sahejkm Sahejkm changed the title test Remove noisy running time signal mentioned in #6138 May 30, 2024
@Sahejkm Sahejkm changed the title Remove noisy running time signal mentioned in #6138 Remove noisy running time signal mentioned in #6137 May 30, 2024
@lexical-bot lexical-bot added the extended-tests Run extended e2e tests on a PR label May 30, 2024
@Sahejkm Sahejkm added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 81f8152 May 30, 2024
39 checks passed
@phazingazrael phazingazrael mentioned this pull request Jun 26, 2024
Open
@phazingazrael phazingazrael mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahejkm @potatowagon @facebook-github-bot @lexical-bot