Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-dev-tools-core] Feature: Index tree view cmds #6182

Merged
merged 2 commits into from
May 28, 2024

Conversation

potatowagon
Copy link
Contributor

Description

I always get confused which way the commands list is flowing in the debug view, so adding an index to show that clearly

it also helps show that commands listed are jumped if > 10 commands get updated in the list

Test plan

Before

Screen.Recording.2024-05-28.at.5.20.46.PM.mov

^ not clear which direction commands are flowing

After

Screen.Recording.2024-05-28.at.5.14.39.PM.mov

^ with index the list is clearer

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2024
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:21am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 9:21am

Copy link

github-actions bot commented May 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 1000 ms (+63.92% 🔺) 1.5 s
packages/lexical-rich-text/dist/LexicalRichText.js 34.59 KB (0%) 692 ms (0%) 1.3 s (+0.89% 🔺) 2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 1.4 s (+22.66% 🔺) 2.1 s

@Sahejkm Sahejkm added the extended-tests Run extended e2e tests on a PR label May 28, 2024
@potatowagon
Copy link
Contributor Author

broken e2e tests dont seem related

Tables › Can copy + paste (internal) using Table

@potatowagon potatowagon added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit a8f4fc8 May 28, 2024
38 of 40 checks passed
@potatowagon potatowagon deleted the index-tree-view-cmds branch May 29, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants