Remove 'legacy-events' from mac & linux e2e matrix #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
reviewed
May 18, 2024
ivailop7
approved these changes
May 20, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
legacy-eventsfrom the e2e test matrix for all OS and browsers exceptchromiumonwindows. I think this removes 12 e2e test runs.The
legacy-eventsversion of e2e tests was adding in Oct 2021 and tests for whenbeforeinputis not available. But the browser support for that event is quite broad these days, mostly in line with the lowest versions of Chrome Meta supports (in practice) internally. So the need to test not-beforeinputdoesn't appear to be significant. I thought we'd keep chromium-windows for now, because Windows is the only OS where we see the oldest versions of Chrome (wherebeforeinputis not supported) being used.