Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Add check for DecoratorNode for horizontal table navigation. #6129

Merged

Conversation

serey-roth
Copy link
Contributor

Description

Pressing the left-arrow key in the first table cell with a decorator node or the right-arrow key in the last table cell with a decorator node previously moved the selection outside the table instead of selecting the node.

Added a check for DecoratorNode when moving horizontally through a table.

Closes: #6128

Test plan

Before

https://www.loom.com/share/98a1761d09574eb895290b80bfcf85ef?sid=134ed533-67b9-42da-bf2d-06d12bb053a8

https://www.loom.com/share/9a2d3376839b4c48b0a672a0ee0207c3?sid=6b6d2918-d603-4974-a314-17063571c492

After

https://www.loom.com/share/269473b64fbb4c7eb34f5aca0a9d1ee5?sid=bdaa7cad-ecc8-4841-a844-932b8e72621c

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 5:29pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 5:29pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2024
@ivailop7 ivailop7 added this pull request to the merge queue May 19, 2024
Merged via the queue into facebook:main with commit 94f8614 May 19, 2024
11 of 12 checks passed
@serey-roth serey-roth deleted the serey/table/horizontal-navigation branch July 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants