Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Add label and run extended test on approve #6117

Closed
wants to merge 18 commits into from
Closed

[Lexical] Add label and run extended test on approve #6117

wants to merge 18 commits into from

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 16, 2024

@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 3:46am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 3:46am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 227 ms (+362.42% 🔺) 705 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.56 KB (0%) 692 ms (0%) 206 ms (+49.18% 🔺) 898 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 228 ms (+33.3% 🔺) 918 ms

@Sahejkm Sahejkm marked this pull request as ready for review May 16, 2024 03:47
@Sahejkm Sahejkm requested a review from ivailop7 as a code owner May 16, 2024 03:47
potatowagon
potatowagon approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can try this out, if it works gotta update the docs about the extended-tests label

@github-actions github-actions bot added the extended-tests Run extended e2e tests on a PR label May 16, 2024
@Sahejkm Sahejkm closed this May 16, 2024
@Sahejkm Sahejkm deleted the add_label_on_approve branch May 16, 2024 04:26
@Sahejkm Sahejkm restored the add_label_on_approve branch May 16, 2024 04:26
@Sahejkm Sahejkm deleted the add_label_on_approve branch May 16, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add extended-tests label on approval
3 participants
@Sahejkm @potatowagon @facebook-github-bot