Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Replace code with key to check KeyboardEvents #6110

Merged
merged 9 commits into from
May 17, 2024
Merged

[Lexical] Replace code with key to check KeyboardEvents #6110

merged 9 commits into from
May 17, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 15, 2024 •
edited
Loading

Replace code with key to check KeyboardEvents

Before:

NumPad Return

Screen.Recording.2024-05-16.at.4.33.30.AM.mov

Dvorak Copy

Screen.Recording.2024-05-16.at.4.03.40.AM.mov

After:

NumPad Return

Screen.Recording.2024-05-16.at.4.33.51.AM.mov

Dvorak Copy

Screen.Recording.2024-05-16.at.4.03.00.AM.mov

Android Backspace

WhatsApp.Video.2024-05-17.at.13.45.15.mp4

@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:27am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 2:27am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.91 KB (-0.09% 🔽) 479 ms (-0.09% 🔽) 256 ms (+709.97% 🔺) 734 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.6 KB (+0.02% 🔺) 693 ms (+0.02% 🔺) 205 ms (+77.03% 🔺) 897 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (-0.03% 🔽) 691 ms (-0.03% 🔽) 277 ms (+192.81% 🔺) 967 ms

@Sahejkm Sahejkm added the extended-tests Run extended e2e tests on a PR label May 15, 2024
@Sahejkm Sahejkm removed the extended-tests Run extended e2e tests on a PR label May 16, 2024
@Daniel15 Daniel15 mentioned this pull request May 16, 2024
Merged
@Sahejkm Sahejkm added the extended-tests Run extended e2e tests on a PR label May 17, 2024
@Sahejkm Sahejkm marked this pull request as ready for review May 17, 2024 03:03
potatowagon
potatowagon approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sahejkm Sahejkm added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit d65d142 May 17, 2024
51 checks passed
@potatowagon potatowagon mentioned this pull request Jun 5, 2024
Closed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 left review comments

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahejkm @Daniel15 @potatowagon @facebook-github-bot