Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bug - 6000: Changing the font size when inputting does not take … #6102

Merged
merged 4 commits into from
May 16, 2024
Merged

Fix: Bug - 6000: Changing the font size when inputting does not take … #6102

merged 4 commits into from
May 16, 2024

Conversation

pixelbyaj
Copy link
Contributor

…effect

Description

Describe the changes in this pull request

Closes: #

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:43pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:43pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2024
@pixelbyaj pixelbyaj marked this pull request as ready for review May 14, 2024 16:02
StyleT
StyleT requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Can you pls add screen recordings before/after + add (if possible) some automated tests.

Let me know if you need any help with tests.

@StyleT StyleT added the contribution-week Issues that are good to be picked up for the contribution week label May 14, 2024
@pixelbyaj
Copy link
Contributor Author

Before:

Recording.2024-05-14.185514.mp4

After:

after.mp4

ivailop7
ivailop7 previously approved these changes May 14, 2024
View reviewed changes
StyleT
StyleT previously approved these changes May 14, 2024
View reviewed changes
@StyleT StyleT added the extended-tests Run extended e2e tests on a PR label May 15, 2024
@pixelbyaj pixelbyaj dismissed stale reviews from StyleT and ivailop7 via c06b4b1 May 15, 2024 21:42
@ivailop7 ivailop7 added this pull request to the merge queue May 16, 2024
Merged via the queue into facebook:main with commit ca0a823 May 16, 2024
48 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@StyleT StyleT StyleT left review comments

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. contribution-week Issues that are good to be picked up for the contribution week extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pixelbyaj @StyleT @ivailop7 @facebook-github-bot