Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] #6097 run extended tests on merge_group event #6100

Merged
merged 1 commit into from
May 14, 2024
Merged

[Lexical] #6097 run extended tests on merge_group event #6100

merged 1 commit into from
May 14, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 14, 2024

  • Follow up on Feature: Add extended-tests label on approval #6097 run extended tests on merge group event
  • This is to ensure :
    • No branch is merged without running e2e tests successfully
    • e2e tests are run every time on merge not just if a label is added manually by facebook owner.
  • will need the Merge Queue settings to be enabled 1st before we we could test this

@vercel Vercel
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:41am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:41am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 696 ms (+59.86% 🔺) 1.2 s
packages/lexical-rich-text/dist/LexicalRichText.js 34.56 KB (0%) 692 ms (0%) 1.5 s (+34.37% 🔺) 2.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 1.2 s (+8.2% 🔺) 1.9 s

@StyleT
Copy link
Contributor

StyleT commented May 14, 2024

Wow! 🤩

@Sahejkm Sahejkm added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 563b63c May 14, 2024
10 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahejkm @StyleT @thegreatercurve @facebook-github-bot