Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical][TextNode] Feature: Add test for #6087 #6091

Merged
merged 2 commits into from
May 12, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented May 12, 2024

Description

This PR adds test for #6087

And for the further improvement, It would be nicer if importDOM supports font size or colors. So I added todo about this.

Test plan

recording of the manual reproduction of added test:

2024-05-12.4.22.01.mov

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 7:48am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 7:48am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2024
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the test! Colors might have to be implemented at a product level for now since they're not backward compatible (you can override HTML or Node)

@zurfyx zurfyx merged commit ef268df into facebook:main May 12, 2024
45 checks passed
@2wheeh 2wheeh deleted the test-text-node-import-dom branch May 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants