[lexical-yjs] Bug fix: Fix cursor position after undo in collab mode #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatsiarynaDzibrova
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ivailop7
previously approved these changes
May 9, 2024
There was a problem hiding this comment.
@fantactuka @StyleT @bencarletonn @ebads67 could you guys have a look as well. LGTM to me.
|
@KatsiarynaDzibrova you would need to fix the warns as per the new eslint rule for integrity to pass |
Fixed it |
StyleT
approved these changes
May 10, 2024
|
Awesome work! |
This was referenced May 13, 2024
|
oh, you steal my work?😢 |
|
it is almost same with my code. if you want to use, you should mention me because it is my contribution.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6010, #4846
The current logic uses previous selection for calculating new cursor position, which does not work correctly, if the last action includes adding new text.
Test plan
Before
After