Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #6053 first till proper fix is shipped in #6056 #6058

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 8, 2024

revert #6053 as it create regression.

Hey @2wheeh , thanks for finding the regression and preparing a fix in #6056 , discussed with my peers, since this PR is creating a regression reverting it 1st to reduce the risk.

cc @potatowagon

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 0:49am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 0:49am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.75 KB (0%) 475 ms (0%) 57 ms (+23.5% 🔺) 532 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.28 KB (0%) 686 ms (0%) 132 ms (+17.37% 🔺) 818 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.3 KB (0%) 686 ms (0%) 108 ms (-10.02% 🔽) 794 ms

@Sahejkm Sahejkm merged commit bddd362 into main May 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants