Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples/react-rich-collab] Feature: Added collaboration focused example #6043

Merged
merged 1 commit into from
May 10, 2024
Merged

[examples/react-rich-collab] Feature: Added collaboration focused example #6043

merged 1 commit into from
May 10, 2024

Conversation

StyleT
Copy link
Contributor

@StyleT StyleT commented May 6, 2024 •
edited
Loading

Description

Changes:

  • Adds example that is focused on collaborative capabilities of Lexical
  • Updates documentation significantly in this context

Test plan

Screen.Recording.2024-05-07.at.8.50.49.PM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2024
@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:54am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 0:54am

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.75 KB (0%) 475 ms (0%) 393 ms (+27.6% 🔺) 868 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.28 KB (0%) 686 ms (0%) 1.2 s (+16.16% 🔺) 1.9 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.3 KB (0%) 686 ms (0%) 987 ms (+0.56% 🔺) 1.7 s

@StyleT StyleT force-pushed the fix/collab_example branch from b9f1dd1 to ba4c87e Compare May 7, 2024 00:49
@StyleT StyleT force-pushed the fix/collab_example branch from ba4c87e to c98384c Compare May 7, 2024 00:59
@StyleT StyleT force-pushed the fix/collab_example branch from c98384c to ec3d0ff Compare May 7, 2024 18:46
@StyleT StyleT force-pushed the fix/collab_example branch from ec3d0ff to 7ccb46d Compare May 7, 2024 22:31
@StyleT StyleT force-pushed the fix/collab_example branch from 7ccb46d to aebe364 Compare May 8, 2024 00:48
@StyleT StyleT marked this pull request as ready for review May 8, 2024 01:34
etrepum
etrepum reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! I think this kind of example will really help people get started with collab.

examples/react-rich-collab/src/App.tsx Outdated Show resolved Hide resolved
examples/react-rich-collab/src/App.tsx Outdated Show resolved Hide resolved
examples/react-rich-collab/src/App.tsx Outdated Show resolved Hide resolved
@StyleT StyleT force-pushed the fix/collab_example branch from aebe364 to 77ab80a Compare May 9, 2024 00:53
@StyleT StyleT requested a review from etrepum May 9, 2024 00:53
@StyleT StyleT merged commit 40f6699 into main May 10, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@etrepum etrepum Awaiting requested review from etrepum

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StyleT @etrepum @zurfyx @facebook-github-bot