classic missing await

facebook · May 5, 2024 · fe80950 · fe80950
1 parent 2480a18
commit fe80950
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/lexical-playground/__tests__/e2e/Share.spec.mjs b/packages/lexical-playground/__tests__/e2e/Share.spec.mjs
@@ -11,6 +11,7 @@ import {
   click,
   expect,
   focusEditor,
+  getPageOrFrame,
   html,
   initialize,
   test,
@@ -28,13 +29,13 @@ test.describe('Share', () => {
   test.beforeEach(({isCollab, page}) => initialize({isCollab, page}));
   test('is disabled in collab', async ({page, isCollab}) => {
     test.skip(!isCollab);
-    await focusEditor(page);
-    expect(page.locator('.action-button.share')).toBeDisabled();
+    const leftFrame = getPageOrFrame(page);
+    await expect(leftFrame.locator('.action-button.share')).toBeDisabled();
   });
   test('can share the editor state', async ({page, isCollab, browserName}) => {
     test.skip(isCollab);
-    await focusEditor(page);
 
+    await focusEditor(page);
     const fooHTML = html`
       <p
         class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"

diff --git a/packages/lexical-playground/src/plugins/ActionsPlugin/index.tsx b/packages/lexical-playground/src/plugins/ActionsPlugin/index.tsx
@@ -225,7 +225,7 @@ export default function ActionsPlugin({
       </button>
       <button
         className="action-button share"
-        disabled={isCollabActive}
+        disabled={isCollabActive || INITIAL_SETTINGS.isCollab}
         onClick={() =>
           shareDoc(
             serializedDocumentFromEditorState(editor.getEditorState(), {