[lexical-mark] Bug Fix: Stop MarkNode __ids array deep copy in clone (#…

…6810)

Co-authored-by: Ebad Salehi <[email protected]>

packages/lexical-mark/src/MarkNode.ts

@@ -32,14 +32,14 @@ export type SerializedMarkNode = Spread<
 /** @noInheritDoc */
 export class MarkNode extends ElementNode {
   /** @internal */
-  __ids: Array<string>;
+  __ids: readonly string[];
 
   static getType(): string {
     return 'mark';
   }
 
   static clone(node: MarkNode): MarkNode {
-    return new MarkNode(Array.from(node.__ids), node.__key);
+    return new MarkNode(node.__ids, node.__key);
   }
 
   static importDOM(): null {
@@ -57,13 +57,13 @@ export class MarkNode extends ElementNode {
   exportJSON(): SerializedMarkNode {
     return {
       ...super.exportJSON(),
-      ids: this.getIDs(),
+      ids: Array.from(this.getIDs()),
       type: 'mark',
       version: 1,
     };
   }
 
-  constructor(ids: Array<string>, key?: NodeKey) {
+  constructor(ids: readonly string[], key?: NodeKey) {
     super(key);
     this.__ids = ids || [];
   }
@@ -112,13 +112,13 @@ export class MarkNode extends ElementNode {
 
   getIDs(): Array<string> {
     const self = this.getLatest();
-    return $isMarkNode(self) ? self.__ids : [];
+    return $isMarkNode(self) ? Array.from(self.__ids) : [];
   }
 
   addID(id: string): void {
     const self = this.getWritable();
     if ($isMarkNode(self)) {
-      const ids = self.__ids;
+      const ids = Array.from(self.__ids);
       self.__ids = ids;
       for (let i = 0; i < ids.length; i++) {
         // If we already have it, don't add again
@@ -133,7 +133,7 @@ export class MarkNode extends ElementNode {
   deleteID(id: string): void {
     const self = this.getWritable();
     if ($isMarkNode(self)) {
-      const ids = self.__ids;
+      const ids = Array.from(self.__ids);
       self.__ids = ids;
       for (let i = 0; i < ids.length; i++) {
         if (id === ids[i]) {
@@ -197,7 +197,7 @@ export class MarkNode extends ElementNode {
   }
 }
 
-export function $createMarkNode(ids: Array<string>): MarkNode {
+export function $createMarkNode(ids: readonly string[]): MarkNode {
   return $applyNodeReplacement(new MarkNode(ids));
 }