When creating a new check list, set the checked value of the list i…

…tem to `false` instead of `undefined` (#5978)
facebook · Aug 4, 2024 · f834a04 · f834a04
1 parent 65bdd2c
commit f834a04
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/lexical-list/src/LexicalListItemNode.ts b/packages/lexical-list/src/LexicalListItemNode.ts
@@ -6,7 +6,7 @@
  *
  */
 
-import type {ListNode} from './';
+import type {ListNode, ListType} from './';
 import type {
   BaseSelection,
   DOMConversionMap,
@@ -320,7 +320,14 @@ export class ListItemNode extends ElementNode {
   getChecked(): boolean | undefined {
     const self = this.getLatest();
 
-    return self.__checked;
+    let listType: ListType | undefined;
+
+    const parent = this.getParent();
+    if ($isListNode(parent)) {
+      listType = parent.getListType();
+    }
+
+    return listType === 'check' ? Boolean(self.__checked) : undefined;
   }
 
   setChecked(checked?: boolean): void {

diff --git a/packages/lexical-list/src/formatList.ts b/packages/lexical-list/src/formatList.ts
@@ -297,7 +297,7 @@ export function updateChildrenListItemValue(list: ListNode): void {
       if (child.getValue() !== value) {
         child.setValue(value);
       }
-      if (isNotChecklist && child.getChecked() != null) {
+      if (isNotChecklist && child.getLatest().__checked != null) {
         child.setChecked(undefined);
       }
       if (!$isListNode(child.getFirstChild())) {