Skip to content

Commit

Permalink
[build] Bug Fix: ensure unique artifact name for e2e tests (#6035)
Browse files Browse the repository at this point in the history
  • Loading branch information
etrepum authored May 5, 2024
1 parent 98804b1 commit 92c4721
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ jobs:
CI: true
E2E_EDITOR_MODE: ${{ inputs.editor-mode }}
E2E_EVENTS_MODE: ${{ inputs.events-mode }}
cache_playwright_path: ${{ inputs.os == 'macos-latest' && '~/Library/Caches/ms-playwright' || inputs.os == 'windows-latest' && 'C:\Users\runneradmin\AppData\Local\ms-playwright' || '~/.cache/ms-playwright'}}
cache_playwright_path: ${{ inputs.os == 'macos-latest' && '~/Library/Caches/ms-playwright' || inputs.os == 'windows-latest' && 'C:\Users\runneradmin\AppData\Local\ms-playwright' || '~/.cache/ms-playwright' }}
test_results_path: ${{ inputs.os == 'windows-latest' && '~/.npm/_logs/' || 'test-results/' }}
test_script: test-e2e-${{ inputs.editor-mode == 'rich-text-with-collab' && 'collab-' || '' }}${{ inputs.prod && 'prod-' || '' }}ci-${{ inputs.browser }}
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ inputs.node-version }}
Expand Down Expand Up @@ -49,11 +50,11 @@ jobs:
path: ${{ env.cache_playwright_path }}
key: ${{ steps.playwright-cache.outputs.cache-primary-key }}
- name: Run tests
run: npm run test-e2e-${{ inputs.editor-mode == 'rich-text-with-collab' && 'collab-' || ''}}${{ inputs.prod && 'prod-' || '' }}ci-${{ inputs.browser }}
run: npm run ${{ env.test_script }}
- name: Upload Artifacts
if: failure()
uses: actions/upload-artifact@v4
with:
name: Test Results
name: Test Results ${{ inputs.os }}-${{ inputs.browser }}-${{ inputs.editor-mode }}-${{ inputs.events-mode }}-${{ inputs.prod && 'prod' || 'dev' }}-${{ inputs.node-version }}
path: ${{ env.test_results_path }}
retention-days: 7
14 changes: 8 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
"@types/jsdom": "^21.1.6",
"@types/katex": "^0.16.7",
"@types/node": "^17.0.31",
"@types/prettier": "^2.7.3",
"@types/prismjs": "^1.26.0",
"@types/react": "^18.0.8",
"@types/react-dom": "^18.0.3",
Expand Down

0 comments on commit 92c4721

Please sign in to comment.