Fix endless renders with editorRef callback (#5701)

facebook · Mar 11, 2024 · 8d37645 · 8d37645
1 parent 830b7e1
commit 8d37645
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/packages/lexical-react/src/LexicalEditorRefPlugin.tsx b/packages/lexical-react/src/LexicalEditorRefPlugin.tsx
@@ -26,10 +26,15 @@ export function EditorRefPlugin({
     | MutableRefObject<LexicalEditor | null | undefined>;
 }): null {
   const [editor] = useLexicalComposerContext();
-  if (typeof editorRef === 'function') {
-    editorRef(editor);
-  } else if (typeof editorRef === 'object') {
-    editorRef.current = editor;
-  }
+
+  React.useEffect(() => {
+    if (typeof editorRef === 'function') {
+      editorRef(editor);
+    } else if (typeof editorRef === 'object') {
+      editorRef.current = editor;
+    }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [editor]);
+
   return null;
 }