rename to onwarn

facebook · May 4, 2024 · 3f96a80 · 3f96a80
1 parent 54d7282
commit 3f96a80
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 12 deletions.
diff --git a/packages/lexical-playground/src/Editor.tsx b/packages/lexical-playground/src/Editor.tsx
@@ -73,6 +73,7 @@ import YouTubePlugin from './plugins/YouTubePlugin';
 import ContentEditable from './ui/ContentEditable';
 import Placeholder from './ui/Placeholder';
 import onError from './utils/onError';
+import onWarn from './utils/onWarn';
 
 const skipCollaborationInit =
   // @ts-expect-error
@@ -157,6 +158,7 @@ export default function Editor(): JSX.Element {
         <LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL
           blockNodes={BLOCK_NODES}
           onError={onError}
+          onWarn={onWarn}
         />
         {isRichText ? (
           <>

diff --git a/packages/lexical-playground/src/utils/onWarn.ts b/packages/lexical-playground/src/utils/onWarn.ts
@@ -0,0 +1,11 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ */
+
+export default function onWarn(message: string) {
+  console.warn(message);
+}
diff --git a/packages/lexical-react/flow/LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL.js.flow b/packages/lexical-react/flow/LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL.js.flow
@@ -16,14 +16,14 @@ export type BlockNodeKlass<T> = Class<BlockNode<T>>;
 
 declare export function LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL(props: {
   onError?: (message: string) => void;
-  onInfo?: (message: string) => void;
+  onWarn?: (message: string) => void;
   blockNodes: Array<Class<React.Node>>;
 }): React$Node;
 
 declare export function registerBlockNodeNormalizerPlugin__EXPERIMENTAL<T>(
   editor: LexicalEditor,
   nodes: Array<Class<T>>, {
     onError?: (message: string) => void;
-    onInfo?: (message: string) => void;
+    onWarn?: (message: string) => void;
   },
 ): () => void;
diff --git a/packages/lexical-react/src/LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL.tsx b/packages/lexical-react/src/LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL.tsx
@@ -6,8 +6,6 @@
  *
  */
 
-
-
 import type {
   DecoratorNode,
   ElementNode,
@@ -44,25 +42,25 @@ const emptyFunction = () => {};
  *
  * @param blockNodes array of blockNode (aka elementNode.isInline() === false)
  * @param onError won't be fixed
- * @param onInfo
+ * @param onWarn
  */
 export function LexicalBlockNodeNormalizerPlugin__EXPERIMENTAL({
   blockNodes,
   onError,
-  onInfo,
+  onWarn,
 }: {
   onError?: (message: string) => void;
-  onInfo?: (message: string) => void;
+  onWarn?: (message: string) => void;
   blockNodes: Array<BlockNodeKlass<JSX.Element>>;
 }): null {
   const [editor] = useLexicalComposerContext();
 
   useEffect(() => {
     return registerBlockNodeNormalizerPlugin__EXPERIMENTAL(editor, blockNodes, {
       onError,
-      onInfo,
+      onWarn,
     });
-  }, [editor, blockNodes, onError, onInfo]);
+  }, [editor, blockNodes, onError, onWarn]);
 
   return null;
 }
@@ -72,10 +70,10 @@ export function registerBlockNodeNormalizerPlugin__EXPERIMENTAL<T>(
   nodes: Array<BlockNodeKlass<T>>,
   optional: {
     onError?: (message: string) => void;
-    onInfo?: (message: string) => void;
+    onWarn?: (message: string) => void;
   } = {},
 ): () => void {
-  const {onError = emptyFunction, onInfo = emptyFunction} = optional;
+  const {onError = emptyFunction, onWarn = emptyFunction} = optional;
   let lastPasteCommand = 0;
 
   const nodeTransform = (node: BlockNode<T>) => {
@@ -106,7 +104,7 @@ export function registerBlockNodeNormalizerPlugin__EXPERIMENTAL<T>(
     // Log structural issues only once, and then separate events if it's
     // related to copy-pasting
     const isPasting = lastPasteCommand + 250 > Date.now();
-    onInfo(
+    onWarn(
       `Found top level node ${node.getKey()} ${
         node.constructor.name
       } inside ${parent.getKey()} ${parent.constructor.name}${