Skip to content

Commit

Permalink
Remove experimental from TerseWrite
Browse files Browse the repository at this point in the history 
Summary: TerseWrite is no longer an experimental feature.

Reviewed By: yoney

Differential Revision: D67614380

fbshipit-source-id: 4a03668e82f57976700c2faaf477e467d0924fba
  • Loading branch information
@thedavekwon @facebook-github-bot
thedavekwon authored and facebook-github-bot committed Jan 2, 2025
1 parent 1e037c5 commit fceeeef
Show file tree
Hide file tree
Showing 29 changed files with 429 additions and 531 deletions.
1 change: 0 additions & 1 deletion thrift/annotation/thrift.thrift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ struct RequiresBackwardCompatibility {
@scope.Struct
@scope.Exception
@scope.Field
@Experimental
struct TerseWrite {}

/** Indicates that an optional field's value should never be stored on the stack,
Expand Down
4 changes: 0 additions & 4 deletions thrift/compiler/test/fixtures/adapter/out/hack/gen-hack/thrift_types.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -566,10 +566,6 @@ public static function getAllStructuredAnnotations()[write_props]: \TStructAnnot
shape(
)
),
'\facebook\thrift\annotation\Experimental' => \facebook\thrift\annotation\Experimental::fromShape(
shape(
)
),
],
'fields' => dict[
],
Expand Down
92 changes: 46 additions & 46 deletions thrift/compiler/test/fixtures/adapter/out/json/gen-json/thrift.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"enumerations" : {
"RpcPriority" : {
"lineno" : 222,
"lineno" : 221,
"constants" : {
"HIGH_IMPORTANT" : 0,
"HIGH" : 1,
Expand All @@ -18,11 +18,11 @@
},
"source_range" : {
"begin" : {
"line" : 222,
"line" : 221,
"column" : 1
},
"end" : {
"line" : 228,
"line" : 227,
"column" : 2
}
}
Expand Down Expand Up @@ -140,139 +140,139 @@
"column" : 1
},
"end" : {
"line" : 107,
"line" : 106,
"column" : 21
}
}
},
"Box" : {
"lineno" : 139,
"lineno" : 138,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 139,
"line" : 138,
"column" : 1
},
"end" : {
"line" : 140,
"line" : 139,
"column" : 14
}
}
},
"Mixin" : {
"lineno" : 146,
"lineno" : 145,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 146,
"line" : 145,
"column" : 1
},
"end" : {
"line" : 147,
"line" : 146,
"column" : 16
}
}
},
"SerializeInFieldIdOrder" : {
"lineno" : 157,
"lineno" : 156,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 157,
"line" : 156,
"column" : 1
},
"end" : {
"line" : 159,
"line" : 158,
"column" : 34
}
}
},
"BitmaskEnum" : {
"lineno" : 165,
"lineno" : 164,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 165,
"line" : 164,
"column" : 1
},
"end" : {
"line" : 166,
"line" : 165,
"column" : 22
}
}
},
"ExceptionMessage" : {
"lineno" : 190,
"lineno" : 189,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 190,
"line" : 189,
"column" : 1
},
"end" : {
"line" : 191,
"line" : 190,
"column" : 27
}
}
},
"InternBox" : {
"lineno" : 197,
"lineno" : 196,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 197,
"line" : 196,
"column" : 1
},
"end" : {
"line" : 199,
"line" : 198,
"column" : 20
}
}
},
"Serial" : {
"lineno" : 204,
"lineno" : 203,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 204,
"line" : 203,
"column" : 1
},
"end" : {
"line" : 205,
"line" : 204,
"column" : 17
}
}
},
"Uri" : {
"lineno" : 210,
"lineno" : 209,
"is_exception" : false,
"is_union" : false,
"fields" : {
Expand All @@ -282,29 +282,29 @@
"required" : true,
"source_range" : {
"begin" : {
"line" : 212,
"line" : 211,
"column" : 3
},
"end" : {
"line" : 212,
"line" : 211,
"column" : 19
}
}
}
},
"source_range" : {
"begin" : {
"line" : 210,
"line" : 209,
"column" : 1
},
"end" : {
"line" : 213,
"line" : 212,
"column" : 2
}
}
},
"Priority" : {
"lineno" : 218,
"lineno" : 217,
"is_exception" : false,
"is_union" : false,
"fields" : {
Expand All @@ -314,29 +314,29 @@
"required" : true,
"source_range" : {
"begin" : {
"line" : 220,
"line" : 219,
"column" : 3
},
"end" : {
"line" : 220,
"line" : 219,
"column" : 24
}
}
}
},
"source_range" : {
"begin" : {
"line" : 218,
"line" : 217,
"column" : 1
},
"end" : {
"line" : 221,
"line" : 220,
"column" : 2
}
}
},
"DeprecatedUnvalidatedAnnotations" : {
"lineno" : 233,
"lineno" : 232,
"is_exception" : false,
"is_union" : false,
"fields" : {
Expand All @@ -346,59 +346,59 @@
"required" : true,
"source_range" : {
"begin" : {
"line" : 235,
"line" : 234,
"column" : 3
},
"end" : {
"line" : 235,
"line" : 234,
"column" : 32
}
}
}
},
"source_range" : {
"begin" : {
"line" : 233,
"line" : 232,
"column" : 1
},
"end" : {
"line" : 236,
"line" : 235,
"column" : 2
}
}
},
"AllowReservedIdentifier" : {
"lineno" : 248,
"lineno" : 247,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 248,
"line" : 247,
"column" : 1
},
"end" : {
"line" : 249,
"line" : 248,
"column" : 34
}
}
},
"AllowReservedFilename" : {
"lineno" : 251,
"lineno" : 250,
"is_exception" : false,
"is_union" : false,
"fields" : {

},
"source_range" : {
"begin" : {
"line" : 251,
"line" : 250,
"column" : 1
},
"end" : {
"line" : 252,
"line" : 251,
"column" : 32
}
}
Expand Down
4 changes: 0 additions & 4 deletions thrift/compiler/test/fixtures/basic-annotations/out/hack/gen-hack/thrift_types.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -570,10 +570,6 @@ public static function getAllStructuredAnnotations()[write_props]: \TStructAnnot
shape(
)
),
'\facebook\thrift\annotation\Experimental' => \facebook\thrift\annotation\Experimental::fromShape(
shape(
)
),
],
'fields' => dict[
],
Expand Down
Loading

0 comments on commit fceeeef

Please sign in to comment.