Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-vercel-analytics): add new vercel analytics plugin #9687
feat(plugin-vercel-analytics): add new vercel analytics plugin #9687
Changes from 16 commits
aace0bc
e6d2bf8
9dfea26
76dd26c
0164c90
522f73e
fcabc25
16242ff
6dc660e
772f1bf
9461ad7
9d761ee
3847883
67576cb
097f2b4
b243a96
3c1d5b1
9730346
db11c27
065f686
b5a2efb
f85345b
42bb53b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
undefined
("auto") makes more sense as a defaultFor example
docusaurus build --dev
builds the site with node env "development" and we probably want it to impact the vercel plugin env in that case.See also:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean with
undefined
("auto") but I changed the default value to auto which makes more senseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also use
undefined
?https://vercel.com/docs/analytics/package#debug
Similarly I think using
docusaurus build --dev
should turn this plugin to debug modeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, didn't understand the use of
undefined
however modified according to your comment