Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(theme): use JSON-LD instead of microdata for blog structured data #9669
refactor(theme): use JSON-LD instead of microdata for blog structured data #9669
Changes from 18 commits
e0da5cf
6521052
2bc8ca6
25afce0
1df8ce4
7c88ae0
79224e1
c21d57a
c5961ea
4cc7a50
885dbaf
6663726
8ffcb58
ce1b664
3ce60a1
356d8f2
55433eb
e59c882
0be47bd
6d26f5c
84a13d1
20256fa
96073e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this component to be "prop-less" instead, similar to the
<BlogPostPageMetadata />
component aboveThe reason is, prop-less components that users swizzle are less sensitive to internal theme refactors such as adding/removing/renaming props, and are less likely to break on Docusaurus version upgrades.
The structured data component could receive that data by other means:
For the blog metadata, you could use an undocumented "route context" feature that we haven't used much yet but I'd like to move internal usage to it progressively:
Eventually we could put this hook in a blog client export, similarly to what we do for the docs plugin (see code importing
@docusaurus/plugin-content-docs/client
, akadocusaurus/packages/docusaurus-plugin-content-docs/src/client/index.ts
I'd prefer this approach because in the future I'd like to have a parent route for your whole blog that declares this context, and makes it accessible to all the blog pages (not just the blog post page but also tags etc)
Let me know if you need help doing this refactoring, that's a bit out of the scope of supporting structured data 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please help - I don't quite follow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let me know when you finish your changes and I'll take over and do this refactor, and then ready to merge 👍