fix(mdx-loader): prevent Open Graph images from being inserted as base64 #9369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it uses `file-loader` only, which will be used to prevent pages' thumbnails from being inserted into the page as base64 data
to prevent pages' thumbnails from being inserted into the page as base64 data
7 tasks
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
the
Argos
|
LGTM thanks 👍 For now I reverted to output images where they were previously: We only support asset images for now and the way it's implemented is quite hacky. We'll improve later and see if we need to support something else than assets |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
build/assets/assetsfolder:Motivation
This prevents
og:imagefrom being inserted directly into the page as base64 data, which prevents them from being visible on Twitter, Slack, Signal, etc. More details at #9345.Test Plan
Simply build the main website and notice the new
build/assets/assetsfolder.Test links
Deploy preview: https://deploy-preview-9369--docusaurus-2.netlify.app/
Related issues/PRs