Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): avoid rendering empty search box container #7990

Closed
wants to merge 8 commits into from
Closed

fix(theme-classic): avoid rendering empty search box container #7990

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9ecf329
fix(theme-classic): fix empty searchBox
drizzlesconsin Aug 23, 2022
b7aa3bf
Update packages/docusaurus-theme-classic/src/theme/Navbar/Search/inde…
Josh-Cena Aug 23, 2022
1bcfb75
Update packages/docusaurus-theme-classic/src/theme/Navbar/Search/inde…
Josh-Cena Aug 23, 2022
87c7c1c
chore: update NavbarSearch type
drizzlesconsin Aug 23, 2022
77a61c3
Update theme-classic.d.ts
drizzlesconsin Aug 23, 2022
ff51a63
This makes more sense
Josh-Cena Aug 24, 2022
31ee0b0
fix: update judgment condition
drizzlesconsin Aug 24, 2022
efb479e
feat: is child null
drizzlesconsin Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/docusaurus-theme-classic/src/theme-classic.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ declare module '@theme/Navbar/Search' {
readonly className?: string;
}

export default function NavbarSearch(props: Props): JSX.Element;
export default function NavbarSearch(props: Props): JSX.Element | null;
}

declare module '@theme/NavbarItem/DefaultNavbarItem' {
Expand Down Expand Up @@ -1117,7 +1117,7 @@ declare module '@theme/PaginatorNavLink' {
}

declare module '@theme/SearchBar' {
export default function SearchBar(): JSX.Element;
export default function SearchBar(): JSX.Element | null;
}

declare module '@theme/TabItem' {
Expand Down
5 changes: 4 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/Navbar/Search/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ import styles from './styles.module.css';
export default function NavbarSearch({
children,
className,
}: Props): JSX.Element {
}: Props): JSX.Element | null {
if (!children) {
return null;
}
return <div className={clsx(className, styles.searchBox)}>{children}</div>;
}