-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add React 19 support to Docusaurus v3 #10763
Open
slorber
wants to merge
18
commits into
main
Choose a base branch
from
slorber/react-19-peerDeps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +74.6 kB (+0.66%) Total Size: 11.3 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +77.9 kB (+0.66%) Total Size: 11.8 MB
ℹ️ View Unchanged
|
slorber
added
the
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
label
Dec 13, 2024
This was referenced Dec 20, 2024
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…slorber/react-19-peerDeps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
CLA Signed
Signed Facebook CLA
pr: new feature
This PR adds a new API or behavior.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This will probably supersede #10745 by adding React 19 support to Docusaurus v3 in a retro-compatible way.
To ensure it works properly, we'll use React 19 on:
Note: most users shouldn't necessarily upgrade existing sites to React 19 immediately, even though Docusaurus v3 allow it. We don't leverage its new features yet, and it's also a bit heavier.
You can stay on React 18 for now unless you have a good reason to upgrade (monorepo dependencies alignment, leveraging React 19 features on your own...)
Test Plan
CI
Test links
https://deploy-preview-10763--docusaurus-2.netlify.app/