fix: ts-expect-error issue again

facebook · Sep 25, 2023 · f4cac9e · f4cac9e
1 parent 7b603e6
commit f4cac9e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/packages/docusaurus/src/client/exports/__tests__/BrowserOnly.test.tsx b/packages/docusaurus/src/client/exports/__tests__/BrowserOnly.test.tsx
@@ -33,6 +33,7 @@ describe('<BrowserOnly>', () => {
         .create(
           <Context.Provider value>
             <BrowserOnly>
+              {/* @ts-expect-error test */}
               <span>{window.location.href}</span>
             </BrowserOnly>
           </Context.Provider>,
@@ -49,6 +50,7 @@ describe('<BrowserOnly>', () => {
     expect(() => {
       renderer.create(
         <Context.Provider value>
+          {/* @ts-expect-error test */}
           <BrowserOnly> </BrowserOnly>
         </Context.Provider>,
       );

diff --git a/packages/docusaurus/src/client/exports/__tests__/Translate.test.tsx b/packages/docusaurus/src/client/exports/__tests__/Translate.test.tsx
@@ -27,6 +27,7 @@ describe('translate', () => {
   it('rejects when no id or message', () => {
     // TODO tests are not resolving type defs correctly. We need to include test
     // files in a tsconfig file
+    // @ts-expect-error: TS should protect when both id/message are missing
     expect(() => translate({})).toThrowErrorMatchingInlineSnapshot(
       `"Docusaurus translation declarations must have at least a translation id or a default translation message"`,
     );
@@ -56,6 +57,7 @@ describe('<Translate>', () => {
 
   it('rejects when no id or message', () => {
     expect(() =>
+      // @ts-expect-error: TS should protect when both id/message are missing
       renderer.create(<Translate />),
     ).toThrowErrorMatchingInlineSnapshot(
       `"Docusaurus translation declarations must have at least a translation id or a default translation message"`,
@@ -67,6 +69,7 @@ describe('<Translate>', () => {
       renderer.create(
         // eslint-disable-next-line @docusaurus/string-literal-i18n-messages
         <Translate id="foo">
+          {/* @ts-expect-error: for test */}
           <span>aaa</span>
         </Translate>,
       ),