Skip to content

Commit

Permalink
fix(markdown): mdx-code-block should support intentation (#10240)
Browse files Browse the repository at this point in the history
  • Loading branch information
slorber authored Jun 20, 2024
1 parent 97630b4 commit 3a0a2a7
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 2 deletions.
30 changes: 30 additions & 0 deletions packages/docusaurus-utils/src/__tests__/markdownUtils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,36 @@ text\r
`);
});

it('can unwrap indented mdx code block', () => {
expect(
unwrapMdxCodeBlocks(dedent`
# Title
<div>
\`\`\`mdx-code-block
content
\`\`\`
</div>
\`\`\`\`mdx-code-block
content2
\`\`\`\`
text
`),
).toEqual(dedent`
# Title
<div>
content
</div>
content2
text
`);
});

it('works for realistic example', () => {
expect(
unwrapMdxCodeBlocks(dedent`
Expand Down
4 changes: 2 additions & 2 deletions packages/docusaurus-utils/src/markdownUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ export function escapeMarkdownHeadingIds(content: string): string {
export function unwrapMdxCodeBlocks(content: string): string {
// We only support 3/4 backticks on purpose, should be good enough
const regexp3 =
/(?<begin>^|\r?\n)```(?<spaces>\x20*)mdx-code-block\r?\n(?<children>.*?)\r?\n```(?<end>\r?\n|$)/gs;
/(?<begin>^|\r?\n)(?<indentStart>\x20*)```(?<spaces>\x20*)mdx-code-block\r?\n(?<children>.*?)\r?\n(?<indentEnd>\x20*)```(?<end>\r?\n|$)/gs;
const regexp4 =
/(?<begin>^|\r?\n)````(?<spaces>\x20*)mdx-code-block\r?\n(?<children>.*?)\r?\n````(?<end>\r?\n|$)/gs;
/(?<begin>^|\r?\n)(?<indentStart>\x20*)````(?<spaces>\x20*)mdx-code-block\r?\n(?<children>.*?)\r?\n(?<indentEnd>\x20*)````(?<end>\r?\n|$)/gs;

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const replacer = (substring: string, ...args: any[]) => {
Expand Down

0 comments on commit 3a0a2a7

Please sign in to comment.