Adding mock support for the Database trait in AKD #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
dillonrg
reviewed
Jan 4, 2023
dillonrg
reviewed
Jan 4, 2023
Comment on lines
+63
to
+73
| impl<Db: Database> Clone for StorageManager<Db> { | ||
| fn clone(&self) -> Self { | ||
| Self { | ||
| cache: self.cache.clone(), | ||
| transaction: self.transaction.clone(), | ||
| db: self.db.clone(), | ||
| metrics: self.metrics.clone(), | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can't we just derive Clone instead?
Comment on lines
+1186
to
+1192
| let mut updates = vec![]; | ||
| for i in 0..1 { | ||
| updates.push(( | ||
| AkdLabel(format!("hello1{}", i).as_bytes().to_vec()), | ||
| AkdValue(format!("hello1{}", i).as_bytes().to_vec()), | ||
| )); | ||
| } |
There was a problem hiding this comment.
Small nit: I think this can be written out as
let updates = (0..1).map(|i| (AkdLabel(...), AkdVaue(...))).collect();
Comment on lines
+1215
to
+1220
| for i in 0..1 { | ||
| updates.push(( | ||
| AkdLabel(format!("hello1{}", i).as_bytes().to_vec()), | ||
| AkdValue(format!("hello1{}", i + 1).as_bytes().to_vec()), | ||
| )); | ||
| } |
afterdusk
reviewed
Jan 4, 2023
There was a problem hiding this comment.
I can't recall off-hand if we have any AKD user code that creates multiple StorageManagers with the same database struct. If we do, we might run into issues because:
- the database trait no longer inherits
Clone - there's no means of creating a
StorageManagerby passing in anArcof a DB.
Either ways we can address the issue if we run into it - thanks for adding mocking so quickly @slawlor !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #332
Tests to come