Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threatexchange-ci vpdq build, bump action versions #1569

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

ianwal
Copy link
Contributor

@ianwal ianwal commented Mar 23, 2024

Summary

Let me know if you think of something better. Not too experienced with Github Actions, so maybe there is a way to avoid duplicating this. Alternatively, we could shove this in a bash file in vpdq directory and run that instead.

Test Plan

Ran it on my fork and vpdq successfully builds. Other format (unrelated to vpdq) format errors still cause the overall workflow to fail, though.

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @ianwal! Sorry for the delay, I'm looking at both this one and #1570

@Dcallies Dcallies merged commit 283c05b into facebook:main Mar 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants