Fix issue when object dealloc in DFS #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwuzw
commented
Mar 1, 2018
| @@ -112,31 +112,33 @@ - (void)addCandidate:(id)candidate | |||
| @autoreleasepool { | |||
| // Take topmost node in stack and mark it as visited | |||
| FBNodeEnumerator *top = [stack lastObject]; | |||
| // Take object that topmost node monitor | |||
| __weak id object = top.object.object; | |||
There was a problem hiding this comment.
Maybe it needs to mimic storeWeak?
|
|
||
| // Take next adjecent node to that child. Wrapper object can | ||
| // persist iteration state. If we see that node again, it will | ||
| // give us new adjacent node unless it runs out of them | ||
| FBNodeEnumerator *firstAdjacent = [top nextObject]; | ||
| if (firstAdjacent) { | ||
| __weak id firstAdjacentObject = firstAdjacent.object.object; |
There was a problem hiding this comment.
Maybe it needs to mimic storeWeak?
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
NSMutableSetto save objects when we DFS,NSMutableSetusehashto distinguish different objects, in our situation, we useFBNodeEnumerator->FBObjectiveCGraphElement->object's pointer address, but object can be dealloc anytime, refer to Apple Document and tests, we can not add mutable object to a collection.After my tests, for example:
objectsOnPathhas aFBNodeEnumeratorobject A, after some step when DFS, we caught A again, after that,A.object.objectdealloc,A'shashis changed to 0. butobjectsOnPathhaven't realize that change, it leads tocontainsObjectnot accurate when we call[objectsOnPath containsObject: A].