Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Add Github Actions #162

Open
wants to merge 144 commits into
base: master
Choose a base branch
from
Open

Add Github Actions #162

wants to merge 144 commits into from

Conversation

the-broz
Copy link

@the-broz the-broz commented Jun 4, 2024

This PR will add GitHub Actions. Which will compile Linux, macOS and, Windows (gaming os 🤷) and distributes them as a prelease.
This would resolve #148

@the-broz the-broz marked this pull request as ready for review June 4, 2024 18:33
@KubaPro010
Copy link

I can't see any artifacts, where are they? (artifacts are file outputs of the ci, essentially the compiled executable)

@the-broz
Copy link
Author

the-broz commented Jun 4, 2024

Right now the it just does checks on commits and PRs and makes sure that they can be built without issue

@GStudiosX2
Copy link
Contributor

So many commits lmfao

@the-broz
Copy link
Author

the-broz commented Jun 5, 2024

the commits never end

@SticksDev
Copy link
Collaborator

Hi, is this ready for review? I can take a look at it now.

@the-broz
Copy link
Author

the-broz commented Jun 5, 2024

At the moment I'm finishing up windows compilation. If you would like you can review the macOS and Linux workflows.

Copy link

@nickmartin1ee7 nickmartin1ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dotunwrap
Copy link

While this still LGTM and is entirely an MVP of CI/CD with releases, I do want to mention #157 being an issue that was requested and could be moderately resolved by adding a .deb artifact as well here. I think at some point integrating .deb and .rpm artifacts in CI/CD would be a good thing to do while we are still getting ready for stable production and cannot reasonably configure a PPA or repo to add allow users to add to their sources to install from apt or dnf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Github CI/CD
7 participants