-
Notifications
You must be signed in to change notification settings - Fork 152
install script updates #152
base: master
Are you sure you want to change the base?
Conversation
I wish you looked at my pull request, where I already addressed the issues with the Linux and macOS install scripts and even improved them 😕 This PR should've been just the Windows install script in my opinion. |
Fails on Windows 11 Sandbox: |
Hey @ByzantineProcess - that was the environment I tested in. Does the script itself fail or does the compile of Webx fail? I can't seem to reproduce. |
Oh, crap. I'll undo that then. Didn't mean to step over you, I just added .sh to the end. lol |
This installs the msvc toolchain by default even though only the gnu toolchain is needed. So we end up downloading 2 toolchains, which on the VM I'm testing the script on is taking a lot of time Does Start-Process -FilePath $rustup -ArgumentList "-y" -Wait |
It's the compilation of Webx that fails. |
In my testing, (unless it happened very quickly and silently), it didn't seem to install MSVC. I don't have install logs to double-check, I just don't remember Rust trying to install it, as it didn't block the install waiting for the user to install it themselves like it did on another machine I installed napture on. (I can be completely wrong here). |
mine got rewritten 🗿 |
Changed the macOS and Linux scripts to end in .sh
Added Windows setup script. Powershell-based, tested against Windows 11
Let me know if you have any questions