Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

video and audio support #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rosegoldd
Copy link

Adds a video tag and an audio tag, also lowers libadwaita and gtk4 versions to make it more compatible

@jamiw1
Copy link

jamiw1 commented Jun 4, 2024

merge this asap PLEASE I BEG

@jamiw1
Copy link

jamiw1 commented Jun 4, 2024

th-2116288494

@GStudiosX2
Copy link
Contributor

If the version changes stay that will be good for me so I don't need to keep changing them when I'm doing a pr

Copy link

@jamiw1 jamiw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, both video and audio players are broken on Windows 10 (not sure about 11, not able to test), with no output or playback
image
have tried using the both the built-in test site and my own site with the exact same results.
edit: i did NOT mean to make this suggest changes, oops

@face-hh
Copy link
Owner

face-hh commented Jun 4, 2024

currently, both video and audio players are broken on Windows 10 (not sure about 11, not able to test), with no output or playback image have tried using the both the built-in test site and my own site with the exact same results. edit: i did NOT mean to make this suggest changes, oops

If it's Windows it's maybe missing some libraries. Do you have mingw paths set up?

@jamiw1
Copy link

jamiw1 commented Jun 4, 2024

currently, both video and audio players are broken on Windows 10 (not sure about 11, not able to test), with no output or playback image have tried using the both the built-in test site and my own site with the exact same results. edit: i did NOT mean to make this suggest changes, oops

If it's Windows it's maybe missing some libraries. Do you have mingw paths set up?

i do, but i could be missing a library that wasn't included here in the pr

Copy link
Contributor

@GStudiosX2 GStudiosX2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix merge conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants