Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches headless browser from PhantomJS to Nightmare #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fabrik42
Copy link
Owner

I'm thinking about switching the headless browser lib from PhantomJS to Nightmare.

There are some Pros and Cons:

Pro:

  • Nightmare uses Electron, which has much better support for new browser features, e.g. WebGL (we could render screenshots in much more interesting ways).
  • PhantomJS still is buggy sometimes, e.g. when setting the viewport.
  • I've never encountered any SSL Problems with Nightmare, with PhantomJS very often (see readme).
  • I hope for better cross platform compatibility.

Con:

  • More dependencies, need to do an npm install
  • Nightmare docs are as bad as the PhantomJS docs. :( (got help in the GH issues)
  • Still need to figure out, how to make better use of the ES generators feature in this project.

Feedback is very welcome!

Best,

Christian

now we don't to call it with the harmony flag anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant