Switches headless browser from PhantomJS to Nightmare #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm thinking about switching the headless browser lib from PhantomJS to Nightmare.
There are some Pros and Cons:
Pro:
Con:
npm install
Nightmare docs are as bad as the PhantomJS docs. :((got help in the GH issues)Still need to figure out, how to make better use of the ES generators feature in this project.Feedback is very welcome!
Best,
Christian