Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VALIDATED to COMLETED #48

Open
wants to merge 1 commit into
base: WIP-v1
Choose a base branch
from
Open

Change VALIDATED to COMLETED #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions standard-covoiturage_openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,17 +811,11 @@ components:
type: string
description: String representing the drop-off address.
status:
type: string
enum:
- WAITING_CONFIRMATION
- CONFIRMED
- CANCELLED
- COMPLETED_PENDING_VALIDATION
- VALIDATED
$ref: '#/components/schemas/bookingStatus'
distance:
type: "integer"
description: |
Carpooling distance in meters. When the booking is COMPLETED or VALIDATED, this is the actual distance travelled if available.
Carpooling distance in meters. When the booking is COMPLETED, this is the actual distance travelled if available.
duration:
type: integer
description: Carpooling duration in seconds.
Expand Down Expand Up @@ -1040,7 +1034,7 @@ components:
- CONFIRMED
- CANCELLED
- COMPLETED_PENDING_VALIDATION
- VALIDATED
Copy link

@ccyrille ccyrille Oct 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @pierrecamilleri,
Non c'est bien VALIDATED qui semble décrire le mieux l'état final. Cela correspond à un trajet qui est non seulement terminé mais aussi définitivement validé par les instances de contrôle (ie: RPC => du point de vue de la lutte contre la fraude notamment).
Par contre COMPLETED_PENDING_VALIDATION pourrait simplement s'appeler COMPLETED.

- COMPLETED
default: WAITING_CONFIRMATION

responses:
Expand Down