Add new data policy fields #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #307 |
|
We're not convinced that 3dp + noise is quite as "imprecise" as we were hoping: will possibly send a follow up PR to make imprecise locations a little noisier |
- enable_forwarding allows forwarding to be enabled or disabled per device - precise_location allows users to choose whether precise (5dp) or approxmite (3dp + 2dp of noise) locations are stored. On deploying we will need to run migrations, then run rake devices:truncate_and_fuzz_locations in order to truncate the existing locations to 5dp.
timcowlishaw
force-pushed
the
data-policy-fields
branch
from
c485da8 to
994b44c
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
(This was just momentary due to the migrations not being run yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_forwarding allows forwarding to be enabled or disabled per device
precise_location allows users to choose whether precise (5dp) or approxmite (3dp + 2dp of noise) locations are stored.
On deploying we will need to run migrations, then run rake devices:truncate_and_fuzz_locations in order to truncate the existing locations to 5dp.