Forwarding of device data #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcowlishaw
force-pushed
the
forwarding-of-device-data
branch
from
5224590 to
aa9a01d
Compare
timcowlishaw
force-pushed
the
forwarding-of-device-data
branch
2 times, most recently
from
94b56dd to
9457093
Compare
|
We should merge #317 first, but this now uses the API device representation as the forwarded payload, and is ready for testing! |
timcowlishaw
force-pushed
the
forwarding-of-device-data
branch
2 times, most recently
from
ef39350 to
bc03313
Compare
timcowlishaw
force-pushed
the
forwarding-of-device-data
branch
from
61a914d to
77a4212
Compare
Users can opt in to have their messages forwarded to an MQTT topic that they subscribe to, identified by a secret forwarding_key
timcowlishaw
force-pushed
the
forwarding-of-device-data
branch
from
77a4212 to
3f2c165
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on #226.
Includes the creation of forwarding tokens for users and logic to decide whether or not to forward, plus the machinery for doing the forwarding. It's involved a bit more refactoring work than i thought as we need to manage the MQTT client object lifecycle a bit more carefully and pass it around to where its needed. For further discussion and testing on staging on Friday!