-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose upgrade #248
Conversation
578f4b6
to
7c791b8
Compare
We should also look into a better way of handling host-specific docker-compose config - one option would be to have a checked-in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Oscar! This is looking good to me - I've fixed a small syntax error in the new compose file, and also:
- renamed to
compose.yml
, the new default - added a
compose.override.local.yml
for local development - expanded the local dev section in the readme to make it clear what this is for
- consistently renamed
docker-compose
todocker compose
everywhere to reflect the new recommended systax
Oh, i've also just split out the compose.yml file into an include for each service, which should make things more manageable! |
c4881d9
to
6f461ca
Compare
Hi @timcowlishaw Some improvements I would suggest for documentation:
|
196ba48
to
283d138
Compare
283d138
to
8b8189a
Compare
8b8189a
to
467c8b3
Compare
467c8b3
to
a178a06
Compare
@timcowlishaw Is it OK for me to merge? |
Hey @oscgonfer ! Aha sure thing, that sounds sensible - i can get to the documentation part later this week! |
This branch is to add changes on the docker-compose example file, in particular to make use of resource limitations and better restart policies of services.
Bear in mind that there is no more version at the beginning of the file, or there shouldn't be.
#235