Fixes tests where NotFound exceptions now return 404 status

spec/controllers/oauth/applications_controller_spec.rb

@@ -76,9 +76,8 @@
 
 
             session[:user_id] = @anotherUser.id
-            expect {
-              get :show, params: { id: @app.id }
-            }.to raise_error(ActiveRecord::RecordNotFound)
+            get :show, params: { id: @app.id }
+            expect(response).to have_http_status :not_found
             #unauthorized
         end
 

spec/controllers/pages_controller_spec.rb

@@ -5,9 +5,8 @@
     it 'not published without current_user' do
       page = FactoryBot.create(:page, published: false)
 
-      expect {
-        get :show, params: { id: page.slug }
-      }.to raise_error(ActiveRecord::RecordNotFound)
+      get :show, params: { id: page.slug }
+      expect(response).to have_http_status :not_found
     end
 
     it 'published' do
@@ -24,9 +23,8 @@
 
       page = FactoryBot.create(:page, published: false)
 
-      expect {
-        get :show, params: { id: page.slug }
-      }.to raise_error(ActiveRecord::RecordNotFound)
+      get :show, params: { id: page.slug }
+      expect(response).to have_http_status :not_found
     end
 
     it 'not published with superadmin current_user' do

spec/features/employees/managing_employees_spec.rb

@@ -13,7 +13,8 @@
     superadmin.add_role :superadmin
     lab.remove(superadmin)
     sign_in_superadmin
-    expect{visit lab_employees_path(lab)}.to raise_error ActiveRecord::RecordNotFound
+    visit lab_employees_path(lab)
+    expect(page).to have_http_status :not_found
   end
 
   scenario "as a superadmin" do

spec/features/recoveries/resetting_your_password_spec.rb

@@ -15,7 +15,8 @@
   end
 
   scenario "with an invalid url" do
-    expect{visit recovery_url('invalidkey')}.to raise_error(ActiveRecord::RecordNotFound)
+    visit recovery_url('invalidkey')
+    expect(page).to have_http_status :not_found
   end
 
   scenario "with an empty password" do