Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wildcard #236

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Wildcard #236

wants to merge 31 commits into from

Conversation

fabiocaccamo
Copy link
Owner

@fabiocaccamo fabiocaccamo commented Jan 18, 2023 •
edited
Loading

Fix #113

milhauzindahauz and others added 29 commits September 12, 2022 23:49
@milhauzindahauz
add wildcard for rename
98f1bf6 
type_util.py - add wildcard index, add only dicts check
__init__.py - clean naive test run
keylist_dict.py - add condition for wildcard key
keylist_util.py - enhance condition for wildcard
@milhauzindahauz
wildcard
d69450a 
tests - modify test
@milhauzindahauz
wildcard
4f8e893 
remove unnecessary imports
@milhauzindahauz
wildcard
7e26ee2 
simplify condition
@milhauzindahauz
wildcard
6987943 
rename function, rename variable
@milhauzindahauz
wildcard
c85c1a4 
use util function
@milhauzindahauz
wildcard
baf4f70 
change conditions blocks
@milhauzindahauz
wildcard
9eba3fc 
remove print function from test
@milhauzindahauz
wildcard
95e3ee8 
add wildcard regex, change _split_key_indexes() to use it
@milhauzindahauz
fix typos
48070d3
@milhauzindahauz
wildcard
1c7da03 
fixes TypeError benedict methods (e.g. swap())
@milhauzindahauz
wildcard
6dfff10 
build few tests, move wildcard test to separate test file
@milhauzindahauz
wildcard
4de87dd 
add is_list to is_list_of_dicts
@milhauzindahauz
wildcard
df926ca 
change tests
@milhauzindahauz
wildcard
409d742 
fix test
@milhauzindahauz
wildcard
38931d6 
add condition for wildcard in keys
@milhauzindahauz
wildcard
b34a803 
implements returning whole list if using wildcard without any other property
add any_wildcard_in_list method
@milhauzindahauz
wildcard
ec6caac 
delete items in list with wildcard
@milhauzindahauz
wildcard
64e355e 
get list by wildcard
@milhauzindahauz
wildcard
87b87b1 
add a bunch of tests
@milhauzindahauz
wildcard
07bdb1b 
empty existing array instead of creating new one
@milhauzindahauz
wildcard
f7401eb 
change conditions order
@milhauzindahauz
wildcard
a631b9a 
add test for multiple wildcards in row
@milhauzindahauz
wildcard
750b78f 
test for wildcard symbol as key
@milhauzindahauz
wildcard
9e136ea 
implements behavior for wildcard chaining, add tests for that
@milhauzindahauz
wildcard
1142a4b 
change behavior, modify test according to it, small refactor of if blocks
@fabiocaccamo
Merge branch 'pr/114' into wildcard
a522ca5
@fabiocaccamo
Merge branch 'master' into wildcard
52ec541
@fabiocaccamo
Merge branch 'main' into wildcard
3e5857a
@fabiocaccamo fabiocaccamo added the enhancement New feature or request label Jan 18, 2023
@fabiocaccamo fabiocaccamo self-assigned this Jan 18, 2023
@fabiocaccamo fabiocaccamo marked this pull request as draft January 18, 2023 10:10
@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Base: 96.93% // Head: 97.02% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (30f8914) compared to base (1280a81).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   96.93%   97.02%   +0.09%     
==========================================
  Files          57       57              
  Lines        1695     1748      +53     
==========================================
+ Hits         1643     1696      +53     
  Misses         52       52
Flag Coverage Δ
unittests 97.02% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
benedict/dicts/__init__.py 100.00% <ø> (ø)
benedict/dicts/keylist/keylist_dict.py 100.00% <100.00%> (ø)
benedict/dicts/keylist/keylist_util.py 100.00% <100.00%> (ø)
benedict/dicts/keypath/keypath_util.py 100.00% <100.00%> (ø)
benedict/utils/type_util.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabiocaccamo fabiocaccamo

Labels
enhancement New feature or request
Projects
Open Source
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wildcard support for renaming
2 participants
@fabiocaccamo @milhauzindahauz