Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

First round of Linux 64-bit fixes. #23

Merged
merged 6 commits into from
May 2, 2015
Merged

First round of Linux 64-bit fixes. #23

merged 6 commits into from
May 2, 2015

Conversation

rohit-n
Copy link
Contributor

@rohit-n rohit-n commented Apr 6, 2015

With these changes, I was able to complete L.A. Meltdown on 64-bit Arch Linux. Ubuntu and Antergos 64-bit Linux were also tested.

2 known issues:

  1. The ending cutscenes after an episode black out after some time.
  2. On my Arch Linux machine, certain sounds (like BAR_MUSIC in E1M2) play too fast.

I have no idea if these fixes work on Windows or Mac 64-bit compiles.

rohit-n added 5 commits April 2, 2015 15:44
@rohit-n
64-bit: Fix initial segfaults.
bef0add 
Game starts up and plays some
of starting demo.
@rohit-n
64-bit: Add bounds check in weapon switching.
de2d608 
j is usually 0 - 11 during regular gameplay,
but is > 4 billion at one point during the
demo. On 32-bit, this doesn't segfault. The
demo now plays to completion.
@rohit-n
64-bit: Sounds now (mostly) play correctly.
5becfc2
@rohit-n
64-bit: Save games read and write without crashing.
caf9454
@rohit-n
64-bit: Fix crashes related to drawing certain sprites
2744754 
through the save game menu and in-game security camera.
@darealshinji
Copy link
Contributor

The game crashes when I look in a mirror and switch to the save menu (Ubuntu 14.04 64 bit).

@rohit-n
Copy link
Contributor Author

rohit-n commented Apr 30, 2015

Thanks for testing. Try it now :)

@fabiensanglard
Copy link
Owner

Do you confirm the crash is not happening anymore ?

@darealshinji
Copy link
Contributor

That did it. It doesn't crash anymore.

fabiensanglard added a commit that referenced this pull request May 2, 2015
@fabiensanglard
Merge pull request #23 from rohit-n/build-64bit
9176462 
First round of Linux 64-bit fixes.
@fabiensanglard fabiensanglard merged commit 9176462 into fabiensanglard:master May 2, 2015
@rohit-n rohit-n deleted the build-64bit branch May 2, 2015 18:02
@rohit-n rohit-n mentioned this pull request May 3, 2015
Open
@fawtytoo
Copy link

fawtytoo commented Feb 22, 2018 •
edited
Loading

I've been commenting on this on another thread, but 64bit still SegFaults. Execution fails on Debian 9.3 64bit. It executes perfectly on Debian 9.3 32bit. Also fails on Ubuntu 17.10 64bit. But it does work on Linux Mint 18.2 64bit.

EDIT: I can use the 64bit binary created on Linux Mint in Debian.

@darealshinji
Copy link
Contributor

I can use the 64bit binary created on Linux Mint in Debian.

Maybe a difference in the used GCC versions. With such old code it may also make a difference which compiler optimizations are enabled (see #31).

@rohit-n rohit-n mentioned this pull request Mar 18, 2019
Closed
@rohit-n
Copy link
Contributor Author

rohit-n commented Mar 18, 2019

@phenest I just made a pull request of fixes for 64-bit. Please try my branch (https://github.com/rohit-n/chocolate_duke3D/tree/build-64bit) and let me know if you have any issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohit-n @darealshinji @fabiensanglard @fawtytoo