Add media type x-www-form-urlencoded #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien0102
reviewed
Apr 19, 2023
| @@ -50,6 +50,11 @@ export const getRequestBodyType = ({ | |||
| return f.createKeywordTypeNode(ts.SyntaxKind.UndefinedKeyword); | |||
| } | |||
|
|
|||
| // NOTE: Maybe not perfect to have this hardcoded here | |||
| if (mediaType.contentType === "application/x-www-form-urlencoded") { | |||
| return f.createTypeReferenceNode("URLSearchParams", undefined); | |||
There was a problem hiding this comment.
Can you add some unit test about this change?
There was a problem hiding this comment.
Sure thing, If would add it to getOperationTypes.test.ts right? What kind of test runner are you using?
There was a problem hiding this comment.
There was a problem hiding this comment.
For the location of the test, I let you decide where this makes sense. The idea is to be sure this will not be broken later and to see that this is working as expected 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the problems in #160. Not sure about the side effects, that this has though, for my OpenAPI file it works fine though^^