Add github actions workflow for perfomance comparison in pull requests #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for valibot canceled.
|
fabian-hiller
added
enhancement
|
Thank you very much! The next few days I have to focus on my bachelor thesis. As soon as I find time, I'll get back to you. |
fabian-hiller
force-pushed
the
main
branch
7 times, most recently
from
b997a0f
to
6d0cde4
Compare
fabian-hiller
force-pushed
the
main
branch
5 times, most recently
from
41ae798
to
4a7ee57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is coupled with another pr #99, which is required for testing this workflow in current pr.
The workflow runs vitest benchmark two times (on pr and main branch), collects its output, compare and format a table with results. This table will be included into sticky comment with following example content:
Performance changes
Measured performance changes between f4e6e99 and f4e6e99.
Show table
Full log and details of before and after benchmark lunch.
The table contains descriptions of tests that contains variants to compare. Variants are sorted by rank (desc sort by after hz value). The negative difference in test results are marked with bold font. If test contains variant, that wasn't present in main branch, its results will be empty. Tests are separated by empty row in the table.
Currently, the workflow will fail, because there aren't any benchmarks in main branch and vitest will fail with exit code 1. The pr #99 solves the problem.
Also the workflow will always be awaiting approval from author to start on every pull request.