Save source and detector locations for 3D data #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayd1860 can you take care of this pull request? |
|
Soon I will update this repo with code from Homer3 itself, some of which may affect the contents of the PR. Thank you for this contribution! |
|
Thank you for considering this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #5. Please let me know if the current behaviour is expected and I will close that issue and this PR.
This PR stores source and detectors in
obj.detectorPos3Dinstead ofobj.detectorPos2Dif 3 dimensions are available. It also writes the 3d variables to disk if they exist.