Improve semantic versioning implementation #147
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rob-luke
commented
Jul 10, 2024
rob-luke
commented
- Modified the release procedure to include roles from the governance doc (which was created after the release procedure).
- Modified the examples in the release procedure to be semantic version compliant.
- Removed the "v" from the document to create a compliant version
- Added "development" to the development version in the doc
- This also helps users understand if they are looking at a released or development version
Horschig
reviewed
Jul 10, 2024
RELEASE.md
Outdated
Comment on lines
8
to
10
| 2. Unanimous approval is required from the steering committee. | ||
| Ensure all steering committee members have explicitly given their approval as a public github comment in the issue. | ||
| 4. Open a pull request that makes the following modifications: |
RELEASE.md
Outdated
| 2. Unanimous approval is required from the steering committee. | ||
| Ensure all steering committee members have explicitly given their approval as a public github comment in the issue. | ||
| 4. Open a pull request that makes the following modifications: | ||
| 1. Modify the version number in the opening lines of the specification to match the version to be released (e.g., `1.0.0`). |
sstucker
approved these changes
Aug 26, 2024
addressing two comments made by @Horschig
samuelpowell
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Current formatting does not render properly in Github Markdown (see guidance
| 3. Open a pull request that makes the following modifications: | ||
| 1. Modify the version number in the opening lines of the specification to match the version to be released (e.g., `v1.0`). | ||
| a. Modify the version number in the opening lines of the specification to match the version to be released (e.g., `1.0.0`). |
There was a problem hiding this comment.
Github is not parsing this markdown as a (sub-) bullet point, it appears inline in the preview text. Likely whitespace or numeral/character mix issue. This applies to all bullets below.
|
Does CHANGELOG also need updating @rob-luke ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.