Add dataOffset field #143
Merged
Add dataOffset field #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed as a 'good idea' in meeting of May 24, @rob-luke to convert to full PR for review. |
|
This seems to address the issue, and does so very simply. Anything preventing this from being completed/merged? |
|
@julien-dubois-k the intention is to proceed with this as soon as possible, @rob-luke I am happy to review when you are ready. |
@samuelpowell I've removed the draft status and it's ready for review |
samuelpowell
approved these changes
Jul 10, 2024
dboas
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of understanding the implications of the simpler proposal from @dboas in #126, I wrote out how it might be implemented. (I always lean into the simple solution first and understand its drawbacks before moving to the more complex option).