Github Actions updates #1841
Merged
Github Actions updates #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to fix the Windows build issue. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Edouard,
This PR does two main things:
Note that I've changed the way the version number is obtained for the .exe, as the existing method didn't work when the Action was run in a forked repository. It's now read from the version number used for CPack that I've written to CMakeCache.txt, which should be more reliable that using the git tag.
Added a command in the Windows build to dump out amount of disk space after the build. After removing the .zip build, we now have 0.67 GB left (Github provides 14GB on D drive).
It also fixes a couple of problems in the source, shown when building on the Mac using Qt6 using the new action.
Yeah - it took a few goes!