Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6880: Skipped normalizing directories in the normalizePath method #393

Merged
merged 1 commit into from
Dec 22, 2023
Merged

IBX-6880: Skipped normalizing directories in the normalizePath method #393

merged 1 commit into from
Dec 22, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Nov 14, 2023

Question Answer
JIRA issue IBX-6880
Type improvement
Target Ibexa version v3.3
BC breaks no

We cannot normalize var_dir as it won't update .yaml config, so perhaps, we should normalize images' filenames only.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Improvement Changes not fixing or changing behavior Ready for review labels Nov 14, 2023
@barw4 barw4 requested a review from a team November 14, 2023 14:56
@barw4 barw4 self-assigned this Nov 14, 2023
@barw4 barw4 marked this pull request as ready for review November 14, 2023 14:59
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ViniTou
ViniTou approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is ok from security standpoint, but I strongly believe this should be fixed on installation. Using unicodes characters in directories is just error prone.

@barw4
Copy link
Member Author

barw4 commented Dec 19, 2023

@ViniTou completely agree, however, var_dir is not fixable on existing images, unfortunately.

@konradoboza konradoboza requested a review from a team December 20, 2023 07:21
tomaszszopinski
tomaszszopinski approved these changes Dec 22, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@alongosz alongosz merged commit 4abba92 into 1.3 Dec 22, 2023
24 checks passed
@alongosz alongosz deleted the ibx-6880-skip-normalizing-image-directories branch December 22, 2023 12:44
@alongosz alongosz mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@barw4 barw4

Labels
Improvement Changes not fixing or changing behavior QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@barw4 @kisztof @ViniTou @konradoboza @tomaszszopinski @mikadamczyk @alongosz