IBX-6592: Content Object State assignment should rely on Location instead of ContentInfo
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect State assignment
2 tasks
barw4
changed the title
Location to be a part of permission check for Object State assignmentLocation instead of ContentInfo
|
Kudos, SonarCloud Quality Gate passed!
|
|
Correct me if I get this wrong. |
Nattfarinn
suggested changes
Nov 30, 2023
Nattfarinn
suggested changes
Nov 30, 2023
| ContentInfo $contentInfo, | ||
| ObjectStateGroup $objectStateGroup, | ||
| ObjectState $objectState, | ||
| ?Location $location = null |
There was a problem hiding this comment.
Is it necessary? This Location parameter does not affect method logic and is just workaround for PermissionResolver. It is also security risk, as not setting this parameter will omit some of limitations checks.
|
Related comment: ezsystems/ezplatform-admin-ui#2112 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3Currently, Content Object State assignment is validated, as permissions go, utilizing
ContentInfowhich in my opinion is wrong, as that leaves Subtree Limitation pretty much useless, and yet, this limitation is available for a choosing when we are dealing with thestate/assignpolicy.To keep BC I've provided a new argument that is
?Location = null. ThisLocationwould be later checked against Subtree Limitation when assigning an Object State to a certain Content.Related PR: ezsystems/ezplatform-admin-ui#2112
Checklist:
$ composer fix-cs).@ezsystems/engineering-team).